Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore opencv-python to a hard dependency #155

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Mar 29, 2023

This PR reverts #126 and #136 and restores opencv-python to a hard dependency in the requirements; this will break certain external user workflows on platforms without a precompiled opencv available.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +0.21 🎉

Comparison is base (52beb28) 72.57% compared to head (8625279) 72.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   72.57%   72.79%   +0.21%     
==========================================
  Files          29       29              
  Lines        5485     5465      -20     
==========================================
- Hits         3981     3978       -3     
+ Misses       1504     1487      -17     
Impacted Files Coverage Δ
tests/test_jump.py 65.95% <ø> (+2.99%) ⬆️
src/stcal/jump/jump.py 15.11% <77.77%> (+1.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett marked this pull request as ready for review March 29, 2023 01:07
@zacharyburnett zacharyburnett added this to the 1.3.5 milestone Mar 29, 2023
@hbushouse hbushouse merged commit 0b18533 into spacetelescope:main Mar 29, 2023
@zacharyburnett zacharyburnett deleted the opencv_hard_dependency branch March 29, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants