Fix issue with bounding box when creating WCS for tests. #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add setting of number_extended_events This was not being set when in single processing mode. * Update CHANGES.rst * Update CHANGES.rst * Update test_jump.py --------- Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
This reverts commit 0eea0e5.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stcal-alignment #181 +/- ##
===================================================
- Coverage 74.95% 74.94% -0.02%
===================================================
Files 32 32
Lines 6202 6198 -4
===================================================
- Hits 4649 4645 -4
Misses 1553 1553
☔ View full report in Codecov by Sentry. |
kmacdonald-stsci
approved these changes
Jul 18, 2023
@kmacdonald-stsci This is a fix for an issue noticed recently during testing. |
|
@nden can you give this final approval from the standpoint of "WCS czar"? |
|
@mairanteodoro and I need to talk about this before merging. |
nden
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue when creating a WCS object for the tests.
The coordinates of the vertices of the bounding box region for the
WCSobject used in the tests were wrongly specified as the center of the pixels instead of the corner (as expected when callingwcs_from_footprint). This PR fixes the unit tests.Checklist
CHANGES.rst(either inBug FixesorChanges to API)