Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3768: Move outlier detection median computers to stcal #292

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Sep 27, 2024

Resolves JP-3768

This PR ports the median calculation machinery added by spacetelescope/jwst#8782 into stcal for use by other missions. See spacetelescope/jwst#8840 for the related changes in jwst.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 99.26740% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.21%. Comparing base (8988d2c) to head (d41546a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/outlier_detection/median.py 98.68% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   84.76%   85.21%   +0.44%     
==========================================
  Files          44       46       +2     
  Lines        8542     8815     +273     
==========================================
+ Hits         7241     7512     +271     
- Misses       1301     1303       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter
Copy link
Collaborator Author

emolter commented Sep 27, 2024

jwst regtests started here
edit: no failures

@emolter emolter marked this pull request as ready for review September 27, 2024 19:19
@emolter emolter requested a review from a team as a code owner September 27, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant