Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crds context in workflow to follow operational context of server #101

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jun 29, 2022

Currently, the GitHub Actions workflow job testing jwst.datamodels fails because the requested and sync'ed CRDS context is different from the operational context on the server. This change ensures that the correct context is sync'ed on every workflow run, and caches and re-uses the current context until it changes.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Jun 29, 2022
@zacharyburnett zacharyburnett self-assigned this Jun 29, 2022
@zacharyburnett zacharyburnett force-pushed the crds_contexts branch 2 times, most recently from b9bfeb1 to 96d25e6 Compare June 29, 2022 17:54
@zacharyburnett zacharyburnett changed the title fix crds version and add additional context to workflow fix crds context in workflow to follow operational context of server Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #101 (5308629) into master (6f5f190) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files          10       10           
  Lines        1714     1714           
=======================================
  Hits         1436     1436           
  Misses        278      278           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7c7af...5308629. Read the comment docs.

@zacharyburnett zacharyburnett marked this pull request as ready for review June 29, 2022 18:09
@zacharyburnett zacharyburnett requested a review from nden June 29, 2022 18:10
@zacharyburnett zacharyburnett merged commit f934400 into spacetelescope:master Jun 30, 2022
@zacharyburnett zacharyburnett deleted the crds_contexts branch June 30, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants