Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of deprecated override__dir__ #103

Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Nov 8, 2022

astropy 5.2 will deprecate override__dir__
The deprecation notes suggest an alternative (used here) which should work for all versions of python >=3.3

Deprecation: https://github.com/astropy/astropy/blob/0944607116f373e64e94ce3e5535c49509897c87/astropy/utils/compat/misc.py#L19
Root python issue: https://bugs.python.org/issue12166
Fixed in 3.3: https://docs.python.org/3.3/whatsnew/changelog.html

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram marked this pull request as ready for review November 8, 2022 17:27
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 83.78% // Head: 83.78% // No change to project coverage 👍

Coverage data is based on head (11721d8) compared to base (11721d8).
Patch has no changes to coverable lines.

❗ Current head 11721d8 differs from pull request most recent head 638481d. Consider uploading reports for the commit 638481d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   83.78%   83.78%           
=======================================
  Files          10       10           
  Lines        1714     1714           
=======================================
  Hits         1436     1436           
  Misses        278      278           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jdavies-st jdavies-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. This code is actually tested by the jwst.datamodels unit tests, not the stdatamodels tests, hence coverage not showing it. Would be good to add the jwst.datamodels tests to coverage.

@nden nden added this to the 0.4.4 milestone Dec 19, 2022
astropy 5.2 will deprecate override__dir__
The deprecation notes suggest an alternative (used here)
which should work for all versions of python >=3.3

Deprecation: https://github.com/astropy/astropy/blob/0944607116f373e64e94ce3e5535c49509897c87/astropy/utils/compat/misc.py#L19
Root python issue: https://bugs.python.org/issue12166
Fixed in 3.3: https://docs.python.org/3.3/whatsnew/changelog.html
@zacharyburnett zacharyburnett merged commit c23d696 into spacetelescope:master Dec 19, 2022
@braingram braingram deleted the bug/astropy_override_dir branch August 15, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants