-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up requires-python
to 3.8
#144
up requires-python
to 3.8
#144
Conversation
Why are we bothering testing on 3.6 and 3.7, astropy and numpy haven't supported those versions in several years now? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 73.13% 65.17% -7.97%
==========================================
Files 101 101
Lines 5438 5438
==========================================
- Hits 3977 3544 -433
- Misses 1461 1894 +433
Flags with carried forward coverage won't be shown. Click here to find out more. see 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
I was just running the tests to make sure; it looks like
so I will up |
requires-python
to 3.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
fixes #142
closes #142
This PR
tests Python 3.6 and Python 3.7updates the minimum Python version required by the package. This will likely change to3.9
whenastropy
andnumpy
drop support for3.8
(#143)Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)