Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up requires-python to 3.8 #144

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Mar 9, 2023

closes #142

This PR tests Python 3.6 and Python 3.7 updates the minimum Python version required by the package. This will likely change to 3.9 when astropy and numpy drop support for 3.8 (#143)

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett self-assigned this Mar 9, 2023
@WilliamJamieson
Copy link
Contributor

Why are we bothering testing on 3.6 and 3.7, astropy and numpy haven't supported those versions in several years now?

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.97 ⚠️

Comparison is base (f0393e0) 73.13% compared to head (8dea516) 65.17%.

❗ Current head 8dea516 differs from pull request most recent head bc6d6b5. Consider uploading reports for the commit bc6d6b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   73.13%   65.17%   -7.97%     
==========================================
  Files         101      101              
  Lines        5438     5438              
==========================================
- Hits         3977     3544     -433     
- Misses       1461     1894     +433     
Flag Coverage Δ
unit 65.17% <ø> (-7.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Mar 9, 2023

I was just running the tests to make sure; it looks like asdf-astropy limits the Python version anyway:
https://github.com/spacetelescope/stdatamodels/actions/runs/4377036134/jobs/7659981886#step:12:31

ERROR: Could not find a version that satisfies the requirement asdf-astropy>=0.3.0 (from versions: 0.1.0, 0.1.1, 0.1.2, 0.2.0, 0.2.1)

so I will up requires-python instead

@zacharyburnett zacharyburnett changed the title test previous Python versions up requires-python to 3.8 Mar 9, 2023
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

fixes #142

@zacharyburnett zacharyburnett merged commit 4206737 into spacetelescope:master Mar 9, 2023
@zacharyburnett zacharyburnett deleted the test_py36 branch March 9, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimum supported python version is out-of-date
3 participants