Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use built-in concurrency configuration for duplicate workflows #151

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 5, 2023

In regards to cancelling duplicate workflows, this PR replaces the cancel_workflows.yml workflow with the built-in concurrency block.

This is:

  1. faster
  2. reduces the amount of workflows in the Actions queue, and
  3. reduces our dependence on third-party workflow actions

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label Apr 5, 2023
@zacharyburnett zacharyburnett self-assigned this Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a800608) 65.22% compared to head (fa5c284) 65.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files         101      101           
  Lines        5450     5450           
=======================================
  Hits         3555     3555           
  Misses       1895     1895           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett changed the title use built-in concurrency configuration use built-in concurrency configuration for duplicate workflows Apr 5, 2023
@zacharyburnett zacharyburnett marked this pull request as ready for review April 5, 2023 17:52
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 5, 2023 17:52
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much cleaner.

@zacharyburnett zacharyburnett merged commit e70a9a0 into spacetelescope:master Apr 5, 2023
@zacharyburnett zacharyburnett deleted the workflow_concurrency branch April 5, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants