Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Mamba to build docs and install graphviz #155

Merged
merged 3 commits into from
Apr 18, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 14, 2023

we can use mambaforge to build docs in an environment and install graphviz (in case dot or graphviz are needed by any Sphinx plugins in the future)

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@zacharyburnett zacharyburnett self-assigned this Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0e37e05) 64.98% compared to head (3a3fe1b) 64.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   64.98%   64.98%           
=======================================
  Files          99       99           
  Lines        5377     5377           
=======================================
  Hits         3494     3494           
  Misses       1883     1883           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett marked this pull request as ready for review April 14, 2023 17:57
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 14, 2023 17:57
Copy link
Contributor

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures are unrelated, they are due to changes in #149 (the matching JWST PR has not been merged yet).

@zacharyburnett zacharyburnett merged commit 96aa254 into spacetelescope:master Apr 18, 2023
@zacharyburnett zacharyburnett deleted the rtd_mamba_env branch April 18, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants