Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3096: Add new JWST keywords to track CR's detected by the jump step #173

Merged
merged 11 commits into from
Jun 23, 2023

Conversation

mwregan2
Copy link
Contributor

@mwregan2 mwregan2 commented Jun 15, 2023

Resolves JP-3096

This PR adds two FITS header keywords that track the rate of regular cosmic rays and shower/snowballs.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@mwregan2 mwregan2 requested a review from a team as a code owner June 15, 2023 19:49
@hbushouse hbushouse changed the title JP-3096 :Jump keywords JP-3096: Add new JWST keywords to track CR's detected by the jump step Jun 21, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a change log entry.

src/stdatamodels/jwst/datamodels/schemas/core.schema.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (134252b) 63.69% compared to head (dae0e37) 63.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   63.69%   63.69%           
=======================================
  Files         100      100           
  Lines        5517     5517           
=======================================
  Hits         3514     3514           
  Misses       2003     2003           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs a change log entry so that we can merge. @mwregan2

@mwregan2
Copy link
Contributor Author

mwregan2 commented Jun 23, 2023 via email

CHANGES.rst Outdated Show resolved Hide resolved
@hbushouse hbushouse added this to the 1.6.1 milestone Jun 23, 2023
@hbushouse hbushouse merged commit 4f8894a into spacetelescope:master Jun 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants