Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs to test paths, fix failing doctest #182

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 8, 2023

pyproject.toml test paths did not include the docs directory. This limited the number of doctests run during pytest runs (and the CI in this package). Downstream testing in asdf revealed this limitation and one failing doctest.

This PR adds the docs directory to the test paths and fixes the one failing doctest.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Jul 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10 🎉

Comparison is base (9281ec1) 63.95% compared to head (3d1352e) 64.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   63.95%   64.06%   +0.10%     
==========================================
  Files         101      101              
  Lines        5565     5565              
==========================================
+ Hits         3559     3565       +6     
+ Misses       2006     2000       -6     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@braingram braingram marked this pull request as ready for review July 8, 2023 17:37
@braingram braingram requested a review from a team as a code owner July 8, 2023 17:37
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@hbushouse hbushouse added this to the 1.7.1 milestone Jul 10, 2023
@braingram braingram merged commit 998528a into spacetelescope:master Jul 10, 2023
16 checks passed
@braingram braingram deleted the doctests branch July 10, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants