-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3349: add keyword_filter ref to gain.schema #197
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 101 101
Lines 5558 5558
=======================================
Hits 3558 3558
Misses 2000 2000 ☔ View full report in Codecov by Sentry. |
Looks good, was just curious to see if we should expect regression test issues stemming from this change, so I started a run here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/871/ |
Thanks for starting the regtests! I was waiting for the server to be free and got distracted :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Resolves JP-3349
Closes spacetelescope/jwst#7832
Add
$ref
tokeyword_filter
schema togain
schema to support themeta.instrument.filter
parameter added to the corresponding miri gain crds file.Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)