Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3349: add keyword_filter ref to gain.schema #197

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Aug 17, 2023

Resolves JP-3349

Closes spacetelescope/jwst#7832

Add $ref to keyword_filter schema to gain schema to support the meta.instrument.filter parameter added to the corresponding miri gain crds file.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (80dd764) 64.01% compared to head (8e83a42) 64.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         101      101           
  Lines        5558     5558           
=======================================
  Hits         3558     3558           
  Misses       2000     2000           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram changed the title add keyword_filter ref to gain.schema JP-3349: add keyword_filter ref to gain.schema Aug 17, 2023
@braingram braingram marked this pull request as ready for review August 17, 2023 16:09
@braingram braingram requested a review from a team as a code owner August 17, 2023 16:09
@tapastro
Copy link
Collaborator

Looks good, was just curious to see if we should expect regression test issues stemming from this change, so I started a run here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/871/

@braingram
Copy link
Collaborator Author

Looks good, was just curious to see if we should expect regression test issues stemming from this change, so I started a run here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/871/

Thanks for starting the regtests! I was waiting for the server to be free and got distracted :)

@braingram
Copy link
Collaborator Author

Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@braingram braingram merged commit 345ae49 into spacetelescope:master Aug 17, 2023
17 checks passed
@braingram braingram deleted the gain_schema branch August 17, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FILTER keyword to GAIN ref file model schema
3 participants