Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3244: Add dither pointing RA/Dec to schema #203

Merged
merged 5 commits into from
Sep 8, 2023

Conversation

tapastro
Copy link
Collaborator

@tapastro tapastro commented Aug 31, 2023

Resolves JP-3244

This PR addresses issues in extraction window centering for MIRI LRS fixed slit observations. Target RA/Dec information is not necessarily accurate, and an alternative was desired. The dither offset from slit center is a known and fixed quantity - we can use this with the transforms and wcsinfo metadata to store the RA/Dec of the dither offset position for extraction centering. It must be stored rather than calculated on the fly because the WCS frames necessary for calculation from existing metadata no longer exist after the product is resampled, prior to extraction.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@tapastro tapastro self-assigned this Aug 31, 2023
@tapastro tapastro requested a review from a team as a code owner August 31, 2023 16:43
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@hbushouse
Copy link
Collaborator

I know this is related to the work being done for JP-3244 to fix extraction aperture centering for NIRSpec FS and MOS, but there are also several existing tickets explicitly for these kinds of extraction problems in MIRI LRS, such as JP-2858 and JP-3021, so referencing those here too.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you envision these 2 keywords only being populated when needed by the MIRI LRS slit mode, or would they be populated for all spectroscopic modes or even imaging modes (that use dithers)?

Do we need them exposed as FITS header keywords or would it be sufficient to just be present in the data model, for use internally in the cal code? Is it useful for them to be visible for users?

@tapastro
Copy link
Collaborator Author

tapastro commented Sep 8, 2023

The initial goal was to have them used for internal purposes only, but they weren't passed through resample_spec if not listed in the schema. I suppose they could be useful to users to see where (modulo a transform) the pipeline placed the extraction center for these exposures. The current PR implementation only populates these for MIRI_LRS-FIXEDSLIT. Apart from a difference in frame, they are not too dissimilar from source_xpos/ypos, but those keywords are defined for slit models, which MIRI LRS does not make use of.

@hbushouse hbushouse merged commit dc90c2d into spacetelescope:master Sep 8, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants