Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miri gain files on CRDS now contain the
BAND
keyword.This PR adds a reference to
keyword_band.schema
togain.schema
.It is not clear to me if at this point the miri gain files should be handled by a more specific schema for the following reasons:
keyword_band.schema
(one examplekeyword_band.schema
listsMEDIUM
which is not listed in the ticket)gain.schema
, used forGainModel
, is used for allgain
reference files on crds. There aregain
files for:fgs
,miri
,nircam
,niriss
andnirspec
. Not all of these use theBAND
keyword and not all of these use theFILTER
keyword. Although apparently not required by the schema this does mean that adding aref
tokeyword_band.schema
means theGainModel
instances for all of these files will now have amodel.meta.instrument.band
attributeRegression tests run with no errors: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/968/
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)