-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace utcnow #231
replace utcnow #231
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
- Coverage 64.67% 64.62% -0.05%
==========================================
Files 102 102
Lines 5662 5660 -2
==========================================
- Hits 3662 3658 -4
- Misses 2000 2002 +2 ☔ View full report in Codecov by Sentry. |
fb19682
to
bb201c6
Compare
entry = HistoryEntry({ | ||
'description': description, | ||
'time': datetime.datetime.utcnow() | ||
'time': dt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not inline dt
inside entry
?
@braingram Could you rebase with latest masters and run the regtests again? |
There's a similar PR for jwst: spacetelescope/jwst#8051 |
bb201c6
to
2611c05
Compare
I don't see the harm in future proofing the code now, even before we're ready to allow py 3.12. That way it's ready to go, and any tests we run against 3.12 won't have this issue. |
Regression tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1058/ |
Regression tests passed with no errors. |
updates use of
utcnow
(deprecated in python 3.12) with an equivalent call that returns a non-timezone aware utc timestampRegression tests: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1023/
Showed the expected niriss failures due to crds file updates and also showed 2 failures:
As these tests appear to sometimes fail (possibly due to test ordering or io buffering) they were re-run in another test run:
https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1026/pipeline/199
where they both passed.
This PR removes one of the python 3.12 failures:
see in a CI run on main:
https://github.com/spacetelescope/stdatamodels/actions/runs/6669314479/job/18126824996
but not seen in the CI run for this PR:
https://github.com/spacetelescope/stdatamodels/actions/runs/6669380674/job/18127057458?pr=231
The remaining failures are due to crds use of
ast.Str
: spacetelescope/crds#1000The crds issues are addressed in: spacetelescope/crds#1007
and a test PR with the changes in this PR and crds shows passing python 3.12 unit tests in stdatamodels: #233
Checklist
CHANGES.rst
(either inBug Fixes
orChanges to API
)