JP-3519: Add noutputs and bunit to readnoise and superbias schemas #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage 64.84% 64.84%
=======================================
Files 103 103
Lines 5694 5694
=======================================
Hits 3692 3692
Misses 2002 2002 ☔ View full report in Codecov by Sentry. |
|
I think the errors should be fixed by #249 Would you rebase this PR and fix the changes conflict? Otherwise looks good to me! |
tapastro
force-pushed
the
jp-3519-readnoise-updates
branch
from
a8888dd
to
cf23293
Compare
braingram
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3519
Closes spacetelescope/jwst#8217
This PR addresses a request to add keyword schemas for noutputs and bunit to the readnoise and superbias schemas, due to CRDS selection criteria updates for these reference files.
Checklist
CHANGES.rst(either inBug FixesorChanges to API)