Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python 2 slicing api #302

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented May 9, 2024

Fixes: #42

These methods are no longer supported as of python 3.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@braingram braingram added the no-changelog-entry-needed Trivial change that doesn't need an entry in the change log label May 9, 2024
@braingram braingram marked this pull request as ready for review May 9, 2024 17:07
@braingram braingram requested a review from a team as a code owner May 9, 2024 17:07
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.42%. Comparing base (4d7c3a6) to head (5bd06ec).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   64.84%   66.42%   +1.58%     
==========================================
  Files         103      101       -2     
  Lines        5694     5445     -249     
==========================================
- Hits         3692     3617      -75     
+ Misses       2002     1828     -174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

down with Python 2! Long live Python 3!

@braingram
Copy link
Collaborator Author

Hopefully we can remove all the 2.0 API before 4.0 is out 😜

@braingram braingram merged commit 0326fd4 into spacetelescope:main May 10, 2024
26 of 27 checks passed
@braingram braingram deleted the remove_slicing branch May 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Trivial change that doesn't need an entry in the change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListNode methods __getslice__, __setslice__, __delslice__ should be removed
2 participants