Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3693: add MEDIUM-DEEP read pattern to schemas #315

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

emolter
Copy link
Contributor

@emolter emolter commented Aug 19, 2024

Resolves JP-3693

Closes JWST 8662

This PR adds the new MEDIUM-DEEP readout pattern to the core schema as well as the readpatt and preadpatt schemas.

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@emolter emolter marked this pull request as ready for review August 19, 2024 16:28
@emolter emolter requested a review from a team as a code owner August 19, 2024 16:28
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (8b27b48) to head (9376300).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   66.21%   66.21%           
=======================================
  Files         101      101           
  Lines        5402     5402           
=======================================
  Hits         3577     3577           
  Misses       1825     1825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as draft August 19, 2024 16:38
@emolter emolter marked this pull request as ready for review August 19, 2024 16:39
@emolter
Copy link
Contributor Author

emolter commented Aug 19, 2024

Not sure what is causing the test failures on main, but the ones here appear to match.

Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tapastro tapastro merged commit a49474c into spacetelescope:main Aug 28, 2024
21 checks passed
@emolter emolter deleted the JP-3693 branch August 28, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new read pattern to schema
3 participants