Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use towncrier to handle change log entries and update new pull request checklist #326

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Sep 10, 2024

old checklist

Checklist

  • added entry in CHANGES.rst (either in Bug Fixes or Changes to API)
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

new checklist

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change the public API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@zacharyburnett zacharyburnett self-assigned this Sep 10, 2024
@zacharyburnett zacharyburnett changed the title use towncrier to handle change log entries use towncrier to handle change log entries and update new pull request checklist Sep 10, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review September 10, 2024 15:37
@zacharyburnett zacharyburnett requested a review from a team as a code owner September 10, 2024 15:37
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.18%. Comparing base (84279cf) to head (9a02d67).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files         100      100           
  Lines        5397     5397           
=======================================
  Hits         3572     3572           
  Misses       1825     1825           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/pull_request_template.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zacharyburnett zacharyburnett merged commit 4adf0cf into spacetelescope:main Sep 11, 2024
21 checks passed
@zacharyburnett zacharyburnett deleted the changelog/towncrier branch September 11, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants