Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_builtin_fits_keyword a public function #47

Conversation

eslavich
Copy link
Collaborator

@eslavich eslavich commented Dec 2, 2020

This function is used in MiriTE, so I removed the underscore from its name and added a test.

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #47 (fae09d9) into master (0d8cade) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files          11       11           
  Lines        1730     1730           
=======================================
  Hits         1382     1382           
  Misses        348      348           
Impacted Files Coverage Δ
src/stdatamodels/fits_support.py 85.90% <80.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8cade...fae09d9. Read the comment docs.

@eslavich eslavich force-pushed the eslavich-publicize-make-is-builtin-fits-keyword branch from 95bfcc2 to fae09d9 Compare December 2, 2020 20:46
@eslavich eslavich merged commit 5292af9 into spacetelescope:master Dec 2, 2020
@eslavich eslavich deleted the eslavich-publicize-make-is-builtin-fits-keyword branch December 2, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants