Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare ci/docs for renaming default branch to main #136

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

braingram
Copy link
Collaborator

This PR updates the CI and docs to refer to a renamed "main" branch.

As no downstream package appears to reference a specific branch for stpipe (and instead uses the default branch) we should be able to:

  • rename the default branch to "main"
  • merge this PR

It's possible codecov may need to be updated to use "main" (if it's not using the default branch).

Github does quite a number of helpful things when the branch is renamed (see https://github.com/github/renaming#renaming-existing-branches) so if acceptable I would propose we rename the branch, merge this PR, and deal with any fallout (although I do not expect any).

xref: spacetelescope/stdatamodels#247

@braingram braingram added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Jan 23, 2024
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cc6214) 59.15% compared to head (87fff8c) 59.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   59.15%   59.15%           
=======================================
  Files          24       24           
  Lines        1611     1611           
=======================================
  Hits          953      953           
  Misses        658      658           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review January 23, 2024 15:29
@braingram braingram requested a review from a team as a code owner January 23, 2024 15:29
@WilliamJamieson WilliamJamieson merged commit aea1617 into spacetelescope:master Feb 5, 2024
16 checks passed
@braingram braingram deleted the rename_to_main branch February 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants