enable nolegacypath tox factor #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
added
the
no-changelog-entry-needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 59.25% 59.25%
=======================================
Files 24 24
Lines 1615 1615
=======================================
Hits 957 957
Misses 658 658 ☔ View full report in Codecov by Sentry. |
braingram
force-pushed
the
no_legacypath
branch
from
0ad3da5
to
44c1250
Compare
|
Thanks @jdavies-st for the review. I just requested @nden for a review to hopefully appease the branch protection (I'm assuming @jdavies-st is not listed as an approved reviewer?). |
nden
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #145
Add a
nolegacypathtox factor that run pytest with-p no:legacypathwhich will produce errors if legacy "non-path" fixtures/features are used.A tox factor was added to allow the downstream jobs (like romancal and jwst) to run without
-p no:legacypathas we are mainly concerned here that stpipe does not use legacy path features in it's test suite (not the test suites of romancal and jwst).