Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Step.closeout #152

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

braingram
Copy link
Collaborator

spacetelescope/jwst#8428 removed the last uses of Step.closeout. This PR removes the method.

@braingram braingram marked this pull request as ready for review May 9, 2024 21:24
@braingram braingram requested a review from a team as a code owner May 9, 2024 21:24
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.46%. Comparing base (484c45d) to head (531f752).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #152       +/-   ##
===========================================
+ Coverage   58.95%   69.46%   +10.50%     
===========================================
  Files          24       24               
  Lines        1652     1634       -18     
===========================================
+ Hits          974     1135      +161     
+ Misses        678      499      -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit d1a0a6d into spacetelescope:main May 10, 2024
16 of 17 checks passed
@braingram braingram deleted the remove_closeout branch May 10, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants