Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull first model from ModelContainers before datamodel methods applied #67

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

tapastro
Copy link
Collaborator

Recent changes to config creation and reference file gathering require a fix for ModelContainer input, so datamodel.crds_parameters() will be run on the contents of the ModelContainer and not the container itself.

@tapastro tapastro requested a review from nden July 28, 2022 14:49
@tapastro tapastro marked this pull request as draft July 28, 2022 14:49
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #67 (d95ddad) into master (fe49a9a) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master     #67   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          25      25           
  Lines        3070    3072    +2     
======================================
- Misses       3070    3072    +2     
Impacted Files Coverage Δ
src/stpipe/step.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe49a9a...d95ddad. Read the comment docs.

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time's a charm!

@tapastro tapastro marked this pull request as ready for review July 28, 2022 16:08
@tapastro tapastro merged commit f7f8ef2 into spacetelescope:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants