Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using isort and black code formatters #80

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

Apply the the code formatters:

  • isort to consistently sort imports
  • black to consistently format the code base.

These will help keep the codebase consistently formatted, and are recommend to be used in conjunction with the ruff linter that stpipe is already using.

I also adjusted the the line-length restriction from 130 down to a more reasonable (and the black standard) length of 88.

Note that this is base on PR #79 and so it should be merged after it.

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.14 ⚠️

Comparison is base (0a1d4eb) 54.17% compared to head (565b035) 54.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   54.17%   54.03%   -0.14%     
==========================================
  Files          25       25              
  Lines        3055     3046       -9     
==========================================
- Hits         1655     1646       -9     
  Misses       1400     1400              
Impacted Files Coverage Δ
src/stpipe/__main__.py 100.00% <ø> (ø)
src/stpipe/cli/__init__.py 100.00% <ø> (ø)
src/stpipe/cli/command.py 72.72% <ø> (ø)
src/stpipe/datamodel.py 61.11% <0.00%> (ø)
src/stpipe/exceptions.py 66.66% <ø> (ø)
src/stpipe/function_wrapper.py 0.00% <ø> (ø)
src/stpipe/hooks.py 0.00% <0.00%> (ø)
src/stpipe/integration.py 100.00% <ø> (ø)
src/stpipe/subproc.py 0.00% <0.00%> (ø)
src/stpipe/tests/test_abstract_datamodel.py 0.00% <ø> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review April 11, 2023 14:07
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner April 11, 2023 14:07
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice commit separation

@WilliamJamieson WilliamJamieson merged commit d8b2f93 into spacetelescope:master Apr 11, 2023
@WilliamJamieson WilliamJamieson deleted the feature/use_code-format branch April 11, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants