-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated deprecated uses of ASDF #82
Updated deprecated uses of ASDF #82
Conversation
eb0dd44
to
825332f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage ? 54.17%
=========================================
Files ? 25
Lines ? 3057
Branches ? 0
=========================================
Hits ? 1656
Misses ? 1401
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
b12a3d2
to
f1331e7
Compare
f1331e7
to
d7d787b
Compare
f5fde0f
to
676cd07
Compare
This PR replaces the legacy AsdfExtension defined in stpipe.integration with a new style resource_mapping.
AsdfExtension is deprecated and will produced DeprecationWarnings in ASDF 2.15 and errors in ASDF 3.0.
https://asdf.readthedocs.io/en/stable/asdf/extending/legacy.html
asdf-format/asdf#1429
While testing for style issues with flake8 an unrelated line was flagged (in tests/test_step.py). This minor change was included here to hopefully avoid any style check failures.