Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for Python 3.8 #93

Merged
merged 2 commits into from
Apr 14, 2023
Merged

drop support for Python 3.8 #93

merged 2 commits into from
Apr 14, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 14, 2023 •
edited
Loading

Numpy is imminently dropping support for Python 3.8

@zacharyburnett zacharyburnett requested a review from a team as a code owner April 14, 2023 15:44
@zacharyburnett zacharyburnett self-assigned this Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7ea7eb) 54.03% compared to head (caa04af) 54.03%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   54.03%   54.03%           
=======================================
  Files          25       25           
  Lines        3046     3046           
=======================================
  Hits         1646     1646           
  Misses       1400     1400

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@braingram
Copy link
Collaborator

Similar to stcal roman (which supports 3.8) tests against the development version of stpipe.
spacetelescope/stcal#162 (comment)

WilliamJamieson
WilliamJamieson requested changes Apr 14, 2023
View reviewed changes
.readthedocs.yaml Outdated
@@ -16,9 +16,13 @@ formats:
- htmlzip
- pdf

build:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you convert this to using mamba like astropy uses.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but that's probably for another PR as it would also require an environment file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the environment you targeted in this PR is causing the docs to fail.

@zacharyburnett zacharyburnett force-pushed the drop_py38 branch 2 times, most recently from 4c5237b to bec2656 Compare April 14, 2023 17:26
@zacharyburnett
Copy link
Collaborator Author

blocked by #94

WilliamJamieson
WilliamJamieson requested changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog.

@zacharyburnett zacharyburnett merged commit 5859cfb into spacetelescope:master Apr 14, 2023
@zacharyburnett zacharyburnett deleted the drop_py38 branch April 14, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamJamieson WilliamJamieson WilliamJamieson approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zacharyburnett @braingram @WilliamJamieson