Merge pull request elastic#61 from spenceralger/empty_dashboard_click

fixed unsafe link when clicking dashboard link with no rows selected
spalger · Jan 23, 2014 · 1ef6232 · 1ef6232
2 parents a564c94 + 87d214c
commit 1ef6232
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/kibana/panels/stats_table/module.js b/kibana/panels/stats_table/module.js
@@ -591,7 +591,6 @@ define([
         return !a ? "" : (a.type === "upper_bound" ? ">" : "<") + y_format_metric_value(a.threshold, metric);
       };
 
-
       $scope.detailViewLink = function (rows, fields) {
         var
         query,
@@ -611,12 +610,11 @@ define([
           };
         });
         if (rows.length === 0) {
-          /*jshint -W107 */
-          return "javascript:;";
+          return null;
         }
         rows = JSON.stringify(rows);
         time = filterSrv.timeRange(false);
-        show;
+
         if (!_.isUndefined(fields)) {
           show = "&show=" + fields.join(",");
         } else {