Update to the circuit breaker settings and stats syntax of 1.4.0

We now have parent, fielddata and request breakers. Also added limits charts for them all. Closes elastic#369 , Closes elastic#368
spalger · Nov 27, 2014 · d307d94 · d307d94
1 parent d3f9bd8
commit d307d94
Show file tree

Hide file tree

Showing 3 changed files with 90 additions and 9 deletions.
diff --git a/agent/src/main/resources/marvel_index_template.json b/agent/src/main/resources/marvel_index_template.json
@@ -42,13 +42,46 @@
     },
     "node_stats": {
       "properties": {
-        "fielddata_breaker": {
+        "breakers": {
           "properties": {
-            "estimated_size_in_bytes": {
-              "type": "long"
+            "fielddata": {
+              "properties": {
+                "estimated_size_in_bytes": {
+                  "type": "long"
+                },
+                "tripped": {
+                  "type": "long"
+                },
+                "limit_size_in_bytes": {
+                  "type": "long"
+                }
+              }
+            },
+            "request": {
+              "properties": {
+                "estimated_size_in_bytes": {
+                  "type": "long"
+                },
+                "tripped": {
+                  "type": "long"
+                },
+                "limit_size_in_bytes": {
+                  "type": "long"
+                }
+              }
             },
-            "tripped": {
-              "type": "long"
+            "parent": {
+              "properties": {
+                "estimated_size_in_bytes": {
+                  "type": "long"
+                },
+                "tripped": {
+                  "type": "long"
+                },
+                "limit_size_in_bytes": {
+                  "type": "long"
+                }
+              }
             }
           }
         },

diff --git a/kibana/dashboards/nodes_stats.js b/kibana/dashboards/nodes_stats.js
@@ -646,16 +646,56 @@ var rows = [
     "title": "Circuit Breakers",
     "panels": [
       {
-        "value_field": "fielddata_breaker.estimated_size_in_bytes",
+        "value_field": "breakers.parent.estimated_size_in_bytes",
+        "mode": "max",
+        "title": "Parent Circuit Breaker Estimated Size",
+        "y_format": "bytes"
+      },
+      {
+        "value_field": "breakers.parent.tripped",
+        "mode": "max",
+        "title": "Parent Circuit Breaker Trip Count"
+      },
+      {
+        "value_field": "breakers.parent.limit_size_in_bytes",
+        "mode": "max",
+        "title": "Parent Circuit Breaker Limit",
+        "y_format": "bytes"
+      },
+      {
+        "value_field": "breakers.fielddata.estimated_size_in_bytes",
         "mode": "max",
         "title": "Field Data Circuit Breaker Estimated Size",
         "y_format": "bytes"
       },
       {
-        "value_field": "fielddata_breaker.tripped",
+        "value_field": "breakers.fielddata.tripped",
         "mode": "max",
         "title": "Field Data Circuit Breaker Trip Count"
-      }      
+      },
+      {
+        "value_field": "breakers.fielddata.limit_size_in_bytes",
+        "mode": "max",
+        "title": "Field Data Circuit Breaker Limit",
+        "y_format": "bytes"
+      },
+      {
+        "value_field": "breakers.request.estimated_size_in_bytes",
+        "mode": "max",
+        "title": "Request Circuit Breaker Estimated Size",
+        "y_format": "bytes"
+      },
+      {
+        "value_field": "breakers.request.tripped",
+        "mode": "max",
+        "title": "Request Circuit Breaker Trip Count"
+      },
+      {
+        "value_field": "breakers.request.limit_size_in_bytes",
+        "mode": "max",
+        "title": "Request Circuit Breaker Limit",
+        "y_format": "bytes"
+      }
     ]
   },
   {

diff --git a/sense/app/kb/api_1_0/cluster.js b/sense/app/kb/api_1_0/cluster.js
@@ -85,8 +85,16 @@ define(function () {
               'allocation.node_concurrent_recoveries': 2,
               'allocation.same_shard.host': { __one_of: [ false, true ]}
             }
+          },
+          indices: {
+            breaker: {
+              "total.limit": "70%",
+              "fielddata.limit": "60%",
+              "fielddata.overhead": 1.03,
+              "request.limit": "40%",
+              "request.overhead": 1.0
+            }
           }
-
         },
         transient: {
           __scope_link: '.persistent'