Replace System.stacktrace with __STACKTRACE__ #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregMefford
approved these changes
Oct 15, 2020
GregMefford
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elixir 1.11 generates deprecation warnings from the use of
System.stacktrace/0in thetracemacro.Eg:
Since the warning is reported as being in my application code (rather than the library), the build fails when compiling with the
--warnings-as-errorsflag.This PR changes the implementation to use
__STACKTRACE__instead, which should be equivalent.I've also updated the minimum elixir version to 1.7, since
__STACKTRACE__isn't supported in lower versions.