Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert tags boolean values different from other atoms #61

Conversation

DReigada
Copy link
Contributor

The Datadog agent trace API only supports strings for metadata keys and values.

We encountered an error when we tried to send tags with booleans as values.

This should convert booleans like we do for other terms.

@DReigada DReigada force-pushed the fix/convert-boolean-tag-values-to-string branch from ed40e6d to 3539242 Compare August 25, 2023 09:57
@DReigada DReigada closed this Aug 25, 2023
@DReigada DReigada reopened this Aug 25, 2023
@DReigada
Copy link
Contributor Author

For some reason GitHub decided to close the PR. Because I mentioned it in another PR (in a private project) 🤦

@GregMefford
Copy link
Member

Thank you for submitting this! It's such a small but helpful change.
It's something that has caught my colleagues and me several times in the past, but I never got around to fixing it. ❤️

@GregMefford GregMefford merged commit ba1c67a into spandex-project:master Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants