Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --grep option #60

Merged
merged 1 commit into from
Jun 8, 2020
Merged

fix --grep option #60

merged 1 commit into from
Jun 8, 2020

Conversation

ilzrv
Copy link
Contributor

@ilzrv ilzrv commented Jun 6, 2020

Without the equal sign I get an error The "--grep" option does not accept a value. But the tests still pass which is incorrect.

From Laravel Docs: https://laravel.com/docs/7.x/artisan#options-with-values

Next, let's take a look at an option that expects a value. If the user must specify a value for an option, suffix the option name with a = sign:

@freekmurze freekmurze merged commit dc93752 into spatie:master Jun 8, 2020
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants