Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generate-temp-token from examples and docs #74

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

anjz
Copy link
Contributor

@anjz anjz commented Oct 18, 2023

Since it's now possible to use api keys for rt and not just short-lived jwt, the examples and docstrings have been updated so that we don't use the generate-temp-token option

Copy link
Collaborator

@HennerM HennerM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really comment on why we want to remove it from the docs, but the code looks fine, approved!

@anjz anjz force-pushed the remove-temp-token-from-examples branch from 58a1447 to 5f52fee Compare October 19, 2023 16:15
@anjz anjz merged commit 1707708 into master Oct 19, 2023
6 checks passed
@anjz anjz deleted the remove-temp-token-from-examples branch October 19, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants