Add support for Audio Events #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumitrugutu
reviewed
Feb 8, 2024
jrg1381
reviewed
Feb 8, 2024
|
add some unit tests to tests/test_cli and tests/test_models |
I don't think these tests are very useful, the test_cli are basically testing argparse and test_models test mostly the asdict method in |
yea its not a big deal in this case, but i think it can be useful to detect errors when you have many config options, and allos you to test the client without building it |
aaronng91
approved these changes
Feb 12, 2024
jrg1381
reviewed
Feb 12, 2024
HennerM
force-pushed
the
audio-events
branch
from
ab1ebad
to
b9409ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.