Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for configuring volume filtering #91

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

jrg1381
Copy link
Contributor

@jrg1381 jrg1381 commented Mar 6, 2024

Supports unreleased volume filtering feature:

{
  "transcription_config": {
    "language": "en",
    "audio_filtering_config": {
      "volume_threshold": 4
    }
  }
}

@jrg1381 jrg1381 requested a review from TudorCRL March 6, 2024 15:02
@@ -230,6 +230,11 @@ def get_transcription_config(
]:
config[option] = True if args.get(option) else config.get(option)

if args.get("volume_threshold"):
config["audio_filtering_config"] = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this be a property in the top level dict?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean audio_filtering_config should be a top level property of the whole thing, or that volume_threshold should be a property in transcription_config?

If the first, then I think audio filtering is a transcription option (and unlike a standalone option configuring a speech capability)

If the second, it's because it follows the related openapi-spec MR and audio_filtering_config is open for extension, even though it only has one setting at the moment - the analogy is with ``speaker_diarization_config`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolving since the openapi-specifications change is merged.

Copy link

@philiprbrown philiprbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrg1381 jrg1381 merged commit 1ad89e5 into master Mar 19, 2024
6 checks passed
@jrg1381 jrg1381 deleted the feature/volume-filtering branch March 19, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants