other pr feedback

Signed-off-by: Spencer Lewis <slewis@squareup.com>
spenceral · Apr 23, 2020 · e5d0b82 · e5d0b82
1 parent e841bd0
commit e5d0b82
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 14 deletions.
diff --git a/source/common/upstream/health_checker_base_impl.cc b/source/common/upstream/health_checker_base_impl.cc
@@ -59,12 +59,12 @@ HealthCheckerImplBase::initTransportSocketOptions(
 MetadataConstSharedPtr HealthCheckerImplBase::initTransportSocketMatchMetadata(
     const envoy::config::core::v3::HealthCheck& config) {
   if (config.has_transport_socket_match_criteria()) {
-    std::unique_ptr<envoy::config::core::v3::Metadata> metadata =
-        std::make_unique<envoy::config::core::v3::Metadata>();
-    metadata->mutable_filter_metadata()->operator[](
-        Envoy::Config::MetadataFilters::get().ENVOY_TRANSPORT_SOCKET_MATCH) =
+    std::shared_ptr<envoy::config::core::v3::Metadata> metadata =
+        std::make_shared<envoy::config::core::v3::Metadata>();
+    (*metadata->mutable_filter_metadata())[Envoy::Config::MetadataFilters::get()
+                                               .ENVOY_TRANSPORT_SOCKET_MATCH] =
         config.transport_socket_match_criteria();
-    return MetadataConstSharedPtr(std::move(metadata));
+    return metadata;
   }
 
   return MetadataConstSharedPtr();

diff --git a/source/common/upstream/upstream_impl.cc b/source/common/upstream/upstream_impl.cc
@@ -241,7 +241,7 @@ HostVector filterHosts(const std::unordered_set<HostSharedPtr>& hosts,
 
 HostDescriptionImpl::HostDescriptionImpl(
     ClusterInfoConstSharedPtr cluster, const std::string& hostname,
-    Network::Address::InstanceConstSharedPtr dest_address, const MetadataConstSharedPtr& metadata,
+    Network::Address::InstanceConstSharedPtr dest_address, MetadataConstSharedPtr metadata,
     const envoy::config::core::v3::Locality& locality,
     const envoy::config::endpoint::v3::Endpoint::HealthCheckConfig& health_check_config,
     uint32_t priority)
@@ -310,9 +310,8 @@ Host::CreateConnectionData HostImpl::createHealthCheckConnection(
     MetadataConstSharedPtr metadata) const {
 
   Network::TransportSocketFactory& factory =
-      (metadata)
-          ? resolveTransportSocketFactory(healthCheckAddress(), metadata.get())
-          : socket_factory_;
+      (metadata) ? resolveTransportSocketFactory(healthCheckAddress(), metadata.get())
+                 : socket_factory_;
   return {createConnection(dispatcher, *cluster_, healthCheckAddress(), factory, nullptr,
                            transport_socket_options),
           shared_from_this()};

diff --git a/source/common/upstream/upstream_impl.h b/source/common/upstream/upstream_impl.h
@@ -73,7 +73,7 @@ class HostDescriptionImpl : virtual public HostDescription,
 public:
   HostDescriptionImpl(
       ClusterInfoConstSharedPtr cluster, const std::string& hostname,
-      Network::Address::InstanceConstSharedPtr dest_address, const MetadataConstSharedPtr& metadata,
+      Network::Address::InstanceConstSharedPtr dest_address, MetadataConstSharedPtr metadata,
       const envoy::config::core::v3::Locality& locality,
       const envoy::config::endpoint::v3::Endpoint::HealthCheckConfig& health_check_config,
       uint32_t priority);

diff --git a/test/mocks/upstream/host.h b/test/mocks/upstream/host.h
@@ -133,10 +133,9 @@ class MockHost : public Host {
     return {Network::ClientConnectionPtr{data.connection_}, data.host_description_};
   }
 
-  CreateConnectionData
-  createHealthCheckConnection(Event::Dispatcher& dispatcher,
-                              Network::TransportSocketOptionsSharedPtr,
-                              MetadataConstSharedPtr) const override {
+  CreateConnectionData createHealthCheckConnection(Event::Dispatcher& dispatcher,
+                                                   Network::TransportSocketOptionsSharedPtr,
+                                                   MetadataConstSharedPtr) const override {
     MockCreateConnectionData data = createConnection_(dispatcher, nullptr);
     return {Network::ClientConnectionPtr{data.connection_}, data.host_description_};
   }