Don't rely on PATH to find sphinx-build #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delfick
force-pushed
the
get-sphinx-build-from-current-python
branch
2 times, most recently
from
4c25da7
to
2000b88
Compare
AA-Turner
reviewed
Sep 17, 2024
delfick
force-pushed
the
get-sphinx-build-from-current-python
branch
from
2000b88
to
689f139
Compare
AA-Turner
reviewed
Sep 18, 2024
This change makes it so that we don't rely on the correct `sphinx-build` being on PATH to build the docs. This is useful when the command that runs sphinx-autobuild runs in a virtualenv that isn't the currently activated virtualenv (i.e. via `uv run --extra docs` invocation)
delfick
force-pushed
the
get-sphinx-build-from-current-python
branch
from
689f139
to
7c37746
Compare
AA-Turner
approved these changes
Sep 18, 2024
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that we don't rely on the correct
sphinx-buildbeing on PATH to build the docs.This is useful when the command that runs sphinx-autobuild runs in a virtualenv that isn't the currently activated virtualenv (i.e. via
uv run --extra docsinvocation)