-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sphinx._cli
#10877
Add sphinx._cli
#10877
Conversation
9fff7d2
to
ac2a54d
Compare
32a6161
to
24db75c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I came across this issue due to looking for a way to build multiple sphinx builders in a single command/call)
I'm not sure what Sphinx's policy is on pulling in dependencies, but might it be worth considering some of:
- https://click.palletsprojects.com/
- https://pypi.org/project/rich-click/
- https://pypi.org/project/typer/
They handle a lot of the "boilerplate" of dealing with arg parsing, subcommads, output and terminal color/encoding etc. (I'm absolutely not trying to bikeshed here)
a85e4fd
to
6b72110
Compare
Out of curiosity, what's the rational for not providing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments inline
This PR is intended to be the first in a series, and just introduces the new CLI infrastructure -- I don't want to provide A |
This is the first step towards a new
sphinx
command.References: #5618, #6938
I took inspiration from @stephenfin's approach but this is a different tack.
Feature or Bugfix
Sample output
A