Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant linting #11789

Closed
wants to merge 1 commit into from
Closed

remove redundant linting #11789

wants to merge 1 commit into from

Conversation

danieleades
Copy link
Contributor

ruff replaces flake8 and isort, so these can be removed

@danieleades danieleades marked this pull request as draft December 10, 2023 08:39
@picnixz
Copy link
Member

picnixz commented Dec 24, 2023 •
edited
Loading

Is the isort integration complete? if we don't use features from isort not supported by ruff, we could consider using ruff only.

@danieleades
Copy link
Contributor Author

Is the isort integration complete? if we don't use features from isort not supported by ruff, we could consider using ruff only.

yes- ruff completely replaces and obviates the need for using isort

@danieleades danieleades mentioned this pull request Dec 25, 2023
Closed
@danieleades danieleades marked this pull request as ready for review December 25, 2023 20:51
@danieleades danieleades marked this pull request as draft December 25, 2023 21:14
@danieleades
Copy link
Contributor Author

converting to draft. I'll revisit this when #11815 has been addressed

@AA-Turner
Copy link
Member

Ruff doesn't yet seem to implement E704 or SIM113, so Flake8 is still required. I've removed isort, though.

A

@AA-Turner AA-Turner closed this Dec 26, 2023
@danieleades
Copy link
Contributor Author

@AA-Turner would you mind reopening this?

SIM113 is supported, as of ruff 0.1.14
E704 was added in february last year, not sure why it's not listed in the docs (i've asked the question)

@danieleades
Copy link
Contributor Author

scratch that, created a new one - #11902

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieleades @picnixz @AA-Turner