-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Empty string enum rendering + Add configurable amount of choices to display #42
Conversation
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 314 309 -5
=========================================
- Hits 314 309 -5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, looks good to me! 🎉
I'd just keep the default value of the option in sync with the tests to make sure the tests really cover the steps below and above the actual limit.
@timoludwig Any news? |
Co-authored-by: Timo Ludwig <ti.ludwig@web.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes! 👍
I added a changelog entry and one additional test for the empty label.
Fixes sphinx-doc#42. The tests intended to capture the issue but actually don't trigger the real issue in the test scenario, so they may not be appropriate. I tried making a 2nd app to see if the deferred issue would show up but it does not.
This PR will fix text choices rendering problem, from issue #41 and also it add completely clear approach to configure amount of choices to render (with sphinx option).
fixes #41
@timoludwig Please merge it