Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Consoles do not work in the bundled app #2841

Closed
ptsavol opened this issue Jun 13, 2024 · 2 comments
Closed

Jupyter Consoles do not work in the bundled app #2841

ptsavol opened this issue Jun 13, 2024 · 2 comments
Assignees
Milestone

Comments

@ptsavol
Copy link
Member

ptsavol commented Jun 13, 2024

Because the bundle is missing jupyter-client and qtconsole packages.

@ptsavol ptsavol added this to the v0.9.0 milestone Jun 13, 2024
@ptsavol ptsavol self-assigned this Jun 13, 2024
ptsavol added a commit that referenced this issue Jun 14, 2024
@ptsavol
Copy link
Member Author

ptsavol commented Jun 14, 2024

Done. Will be in the next development snapshot and upcoming releases.

The following is mostly for @soininen

There was a price to pay. The bundle grew by ~100Mb and the number of files increased from about 8000 to 14000. This is all well and good but upload_artifact@v4 gave me a headache. I was hit by this issue actions/upload-artifact#485 because of the increase in the number of files. I tried using Github's Powershell to create the .zip file (with Compress-Archive cmdlet) before running upload_artifact, so that it would only upload one file instead of 14000. This 'worked' but I was hit by another issue actions/upload-artifact#39. The zip-file was inside another zip file, which I thought would be too confusing for first time users. I ended up using the soon-to-be-deprecated upload_artifact@v3, which does not have issue 485. Unfortunately, the Upload archive step is really slow with v3. I'll change it back to v4 if I get bored waiting and then we'll just have to live a with double zipped bundle until we find a solution.

@ptsavol ptsavol closed this as completed Jun 14, 2024
@soininen
Copy link
Contributor

@PekkaSavolainen Thanks a lot for working on this!

There is a problem with the bundle, though. You really cannot install anything that comes with .exe files such as Pip or Jupyter since the executable files in _internal\Python\Scripts will then have hard-coded paths to the system where the installation was done and do not work. Originally, I tried to have the embedded Python to come with Pip but for that reason I choose not to include it. I am not sure if this is actually an issue for the users since they probably will never try to run the .exe files but it is still a pity we ship a broken Python.

Also the increased bundle size and the issues that come with it worries me. Would it be a possibility to just disable Jupyter in Toolbox if the Python environment does not have it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants