[DEVOPS-635] Refactor waiting for resources to be ready #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jchanam
commented
Dec 26, 2017
•
jchanam
commented
- Move waiting loops to a new functions
- Add wait for deletions
slok
approved these changes
Dec 28, 2017
| } | ||
| } | ||
|
|
||
| func (r *RedisFailoverKubeClient) waitForPodDeletion(name string, namespace string, logger log.Logger) { |
There was a problem hiding this comment.
All this deletion methods could be reduced to one codebase (no code duplication) and pass an interface taht gets the items.
There was a problem hiding this comment.
As we've discussed, It's more complicated to do an interface because runtime.Object does not implement the Items function (for the list). We'd have to do a manual object copy and it does not worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.