Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for nil pointer when getting minimum redis pod time #126

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Check for nil pointer when getting minimum redis pod time #126

merged 1 commit into from
Mar 6, 2019

Conversation

jchanam
Copy link
Collaborator

@jchanam jchanam commented Mar 5, 2019

Fixes #122

Changes proposed on the PR:

  • Check if pod has StartTime to prevent panic of nil pointer

Check for nil pointer when getting minimum redis pod time
7fcad19 
Signed-off-by: Julio Chana <julio@spotahome.com>
@jchanam jchanam requested review from slok, ese and chusAlvarez March 5, 2019 15:01
@jchanam jchanam merged commit b58452f into master Mar 6, 2019
@jchanam jchanam deleted the fix-null-pointer-exception-pod-time branch March 6, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slok slok slok approved these changes

@ese ese Awaiting requested review from ese

@chusAlvarez chusAlvarez Awaiting requested review from chusAlvarez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchanam @slok