Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make command for redis and sentinel configurable #127

Merged
merged 2 commits into from
Mar 6, 2019
Merged

Make command for redis and sentinel configurable #127

merged 2 commits into from
Mar 6, 2019

Conversation

jchanam
Copy link
Collaborator

@jchanam jchanam commented Mar 6, 2019

Fixes #111.

Changes proposed on the PR:

  • Make the command for redis and sentinel configurable by user. If not set, it'll use the defaults.
  • Add information on README.md

Julio Chana added 2 commits March 5, 2019 12:19
Make command for redis and sentinel configurable
37d9aff 
Signed-off-by: Julio Chana <julio@spotahome.com>
Add information about command on readme
134aeba 
Signed-off-by: Julio Chana <julio@spotahome.com>
@jchanam jchanam requested review from slok, ese and chusAlvarez March 6, 2019 10:16
chusAlvarez
chusAlvarez approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@chusAlvarez chusAlvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jchanam jchanam merged commit 1b24e27 into master Mar 6, 2019
@jchanam jchanam deleted the make-command-configurable branch March 6, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chusAlvarez chusAlvarez chusAlvarez approved these changes

@slok slok Awaiting requested review from slok

@ese ese Awaiting requested review from ese

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchanam @marcemq @chusAlvarez