Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels added to mark roles of the Redis Pods as Master and slave #307

Conversation

SuhailRahman
Copy link

Fixes #275

Changes proposed on the PR:

  • Labels were added to the Redis pods as master and slave depending on the roles, this would be helpful when any user would want to access Redis outside of the Kubernetes cluster. The users would have to expose the Redis pods with the label as role: Master and the exposed service would point to the Master Redis pod.

@SuhailRahman SuhailRahman requested a review from ese as a code owner April 14, 2021 14:49
@SuhailRahman
Copy link
Author

@ese please review this

@SuhailRahman
Copy link
Author

@ese can you check this

@SuhailRahman
Copy link
Author

closed this issue by mistake

@SuhailRahman SuhailRahman reopened this Jan 25, 2022
@ese
Copy link
Member

ese commented Jan 25, 2022

Thanks for the patience @SuhailRahman. Due the last updates in the client-go you need to add context parameter to the patch functions.

@ese
Copy link
Member

ese commented Aug 30, 2022

closed by #419

@ese ese closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the right way to expose a redisfailover cluster outside of K8s?
2 participants