Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kustomize #473

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Kustomize #473

merged 3 commits into from
Sep 8, 2022

Conversation

sagikazarmark
Copy link
Contributor

@sagikazarmark sagikazarmark commented Sep 8, 2022

Fixes #377
Fixes #383

Changes proposed on the PR:

  • Add kustomize installation

Couple notes:

  • This PR adds a number of steps to release preparation
    • manifests/kustomize/components/version/kustomization.yaml needs to be updated with the next version
    • in case you want to upload a generated manifest to the GitHub Release page, it has to be done manually for now
    • README has to be updated with the latest version
    • The main branch should always reference the latest stable version (or the latest development version if that's preferred). Therefore, before tagging the image version has to be updated before tagging and reverted afterwards (for example an RC release tag should reference the RC image, but the main branch should continue pointing to the last stable/dev version)
  • The README references v1.2.0 as an example, although it hasn't been released yet
  • The current process copies (duplicates) the CRD file

This setup could later be improved with an automated release mechanism that compiles the final yaml file and publishes it to GitHub Releases.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark requested a review from a team as a code owner September 8, 2022 11:25
@ese
Copy link
Member

ese commented Sep 8, 2022

Great, Thanks for the PR and detailed notes :)

@ese ese merged commit 78dcad4 into spotahome:master Sep 8, 2022
@sagikazarmark sagikazarmark deleted the kustomize branch September 8, 2022 14:12
@sagikazarmark
Copy link
Contributor Author

Thanks for merging. Excited to see this in the next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for creating PodMonitor or ServiceMonitor Improve kustomize experience
2 participants