Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment extensions/v1beta1 deprecated since 1.16, not 1.19 #487

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

panpan0000
Copy link
Contributor

Fixes #486

Changes proposed on the PR:

per https://kubernetes.io/docs/reference/using-api/deprecation-guide/

The extensions/v1beta1, apps/v1beta1, and apps/v1beta2 API versions of Deployment are no longer served as of v1.16.

So this operator is not working under k8s 1.18

@panpan0000 panpan0000 requested a review from a team as a code owner September 21, 2022 02:35
@panpan0000 panpan0000 changed the title Deployment extensions/v1beta1 deprecated since 1.16 Deployment extensions/v1beta1 deprecated since 1.16, not 1.19 Sep 21, 2022
@ese
Copy link
Member

ese commented Sep 21, 2022

Thanks @panpan0000. In fact redis-operator currently only supports Kubernetes => 1.21 so we could actually remove this check at all

@panpan0000
Copy link
Contributor Author

Okay, fine...

my new change:
(1) totally remove the version comparing of Deployment api version.
(2) add strict restriction in charts.yaml , introducing kubeVersion (refer to https://helm.sh/docs/topics/charts/), so warning comes as below and will stop people using this chart :
Error: chart requires kubeVersion: >= 1.21.0-0 which is incompatible with Kubernetes v1.18.20

@ese
Copy link
Member

ese commented Sep 22, 2022

Great! Thanks a lot !

@ese ese merged commit 2c37791 into spotahome:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not working in 1.18, since deployment API version deprecation not handling
2 participants