Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] example yaml image version change #518

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

lvyanru8200
Copy link
Contributor

Signed-off-by: yanru.lv yanru.lv@daocloud.io

Fixes # .

Changes proposed on the PR:

  • example/operator deploy yaml change

Signed-off-by: yanru.lv <yanru.lv@daocloud.io>
@lvyanru8200
Copy link
Contributor Author

#515

@lvyanru8200
Copy link
Contributor Author

/cc @ese

@samof76
Copy link
Contributor

samof76 commented Nov 19, 2022

@lvyanru8200 this is a chicken and egg issue. So its better to keep it as latest.

Signed-off-by: lvyanru <yanru.lv@daocloud.io>
@lvyanru8200
Copy link
Contributor Author

@lvyanru8200 this is a chicken and egg issue. So its better to keep it as latest.

you are right

@samof76
Copy link
Contributor

samof76 commented Nov 22, 2022

@lvyanru8200 looks good!

@ese ese merged commit 94cea5b into spotahome:master Nov 22, 2022
@haslersn
Copy link

It's not a good idea to keep it as latest, because that way you cannot deploy a certain version by downloading the example from the respective git tag. Furthermore, for people who download the example and deploy it via a CI/CD tool, it will most likely break at some point, because a new version of the operator might require different manifests, e.g., more RBAC permissions. Please note that no other major kubernetes operator vendor puts the latest tag in deployment examples; see, e.g., https://github.com/kubernetes/ingress-nginx/blob/2ea010986f8348b259468506a3118dcc34f54b38/deploy/static/provider/baremetal/deploy.yaml#L452.

@haslersn
Copy link

haslersn commented Sep 9, 2023

Adding to my previous comment: It's not only an issue when deploying via CI/CD. Even when simply restarting the operator on a node where the image is not yet present, it will of course pull the latest tag. Disaster is inevitable as soon as a new operator version requires different manifests, e.g., more RBAC permissions or a new CRD version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants