Fix thread safety issue in MP3Compressor. #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127.
LAME's
hip_decode
family of functions makes use of a singlestatic
buffer when decoding MP3 frames. This precludes callinghip_decode
from multiple threads, as each thread will overwrite the buffer's contents.This PR fixes the issue by:
lame_overrides.c
file, which implementship_decode_threadsafe
hip_decode_threadsafe
fromMP3Compressor
instead.(cc @iCorv)