Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pb setter instead of juce setter in noisegate #144

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

iCorv
Copy link
Contributor

@iCorv iCorv commented Aug 28, 2022

NoiseGate: The init-function wrongly uses JUCEs setter

Problem

After calling NoiseGate(), the parameters passed to init only get set in JUCEs NoiseGate-class and not in the pedalboard NoiseGate-class. This can be easily tested with:

noise_gate = pb.NoiseGate(threshold_db=-40, ratio=10, attack_ms=100, release_ms=100)
noise_gate.__repr__

Output:
>>> <bound method PyCapsule.__repr__ of <pedalboard.NoiseGate threshold_db=0 ratio=0 attack_ms=0 release_ms=0 at 0x4905f00>>

Solution

Use pedalboards NoiseGate setter-function, which in turn also sets the parameter in the downstream JUCE class.

@psobot
Copy link
Member

psobot commented Aug 28, 2022

Thanks @iCorv!

@psobot psobot merged commit 8023297 into spotify:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants