use pb setter instead of juce setter in noisegate #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoiseGate: The
init
-function wrongly uses JUCEs setterProblem
After calling
NoiseGate()
, the parameters passed toinit
only get set in JUCEsNoiseGate
-class and not in the pedalboardNoiseGate
-class. This can be easily tested with:Output:
>>> <bound method PyCapsule.__repr__ of <pedalboard.NoiseGate threshold_db=0 ratio=0 attack_ms=0 release_ms=0 at 0x4905f00>>
Solution
Use pedalboards
NoiseGate
setter-function, which in turn also sets the parameter in the downstream JUCE class.