Patch MP3 parser to ignore files that contain Lyrics3 data. #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue discovered by @f90 in which certain MP3 files - notably those that contain Lyrics3v2 data - cannot be read completely by Pedalboard.
The full explanation of the bug:
Failed to read from file.
when it encountered the Lyrics3v2 tag.This PR makes a couple of changes to fix the issue:
juce_overrides
and has been patched to ignore Lyrics3v2 blocks if encountered during parsing.pedalboard.io.ReadableAudioFile
now includes a new constructor parameter,cross_platform_formats_only
, which allows reproduction of this bug on macOS by disabling any platform-specific audio format parsers (like CoreAudio, or Windows Media).